Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add txHash and network to extensions events #669

Merged
merged 1 commit into from
Nov 5, 2021
Merged

fix: add txHash and network to extensions events #669

merged 1 commit into from
Nov 5, 2021

Conversation

kevindavee
Copy link
Contributor

Description of the changes

txHash and network needs to be injected to request.extensions[paymentNetworkId].events[i].parameters in order to make it available on balance.events[i].parameters

@kevindavee kevindavee requested review from AdamREQ and bertux and removed request for vrolland and benjlevesque November 5, 2021 04:59
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 89.252% when pulling 133f884 on fix/declare-payment into 7f35bf0 on master.

@kevindavee kevindavee merged commit 7efaec7 into master Nov 5, 2021
@kevindavee kevindavee deleted the fix/declare-payment branch November 5, 2021 08:50
@bertux bertux removed their request for review November 5, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-abrioux alexandre-abrioux alexandre-abrioux approved these changes

@AdamREQ AdamREQ AdamREQ approved these changes

@KolevDarko KolevDarko Awaiting requested review from KolevDarko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindavee @coveralls @alexandre-abrioux @AdamREQ