Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
NonceManager
from the Request NodeMotivation
(Copied from https://github.com/RequestNetwork/marble/pull/105 written by @alexandre-abrioux)
The
NonceManager
does not handle catching errors from the RPC.When the RPC refuses a transaction, because for instance:
; then an error is thrown and not handled by the
NonceManager
. In that case, theNonceManager
still increases its internal counter.Since the initial transaction was never persisted on-chain, the following transactions are never picked up by the network because their nonce is too high.
More sources:
In ethers.js documentation https://docs.ethers.org/v5/api/experimental/#experimental-noncemanager
In ethers.js code (latest version, v6, not the version we use): https://github.com/ethers-io/ethers.js/blob/v6.9.0/src.ts/providers/signer-noncemanager.ts#L82
there is this comment:
This is the code for the currently used version of ethers.js (v5): https://github.com/ethers-io/ethers.js/blob/v5.5.1/packages/experimental/src.ts/nonce-manager.ts
Additionally, I suspect that the "OldNonce" error was also caused by the
NonceManager
.Fixes #1292