Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: method to merge reprozip pack files #69

Merged
merged 5 commits into from
Aug 11, 2017
Merged

ADD: method to merge reprozip pack files #69

merged 5 commits into from
Aug 11, 2017

Conversation

kaczmarj
Copy link
Collaborator

Adds the cli command neurodocker reprozip-merge to merge multiple pack files. Renames neurodocker reprozip to neurodocker reprozip-trace.

Related to nipy/nipype#2144.

Example

Given multiple ReproZip pack files (.rpz) in the current directory, merge pack files, and save merged pack file in the current directory:

docker run --rm -v $(pwd):/packs --workdir /packs kaczmarj/neurodocker reprozip-merge merged.rpz *.rpz

Create a Docker image from the merged pack file:

reprounzip docker setup merged.rpz merged

Run the new Docker image:

docker run --rm -it --entrypoint="/neurodocker/startup.sh" <reprounzip_docker_image>

@kaczmarj
Copy link
Collaborator Author

Also related to VIDA-NYU/reprozip#265

@schahid
Copy link
Contributor

schahid commented Aug 11, 2017

Hi, nice piece of work!. I am testing it. Please add perl installation while creating Docker file for Freesurfer. as perl is missing, so nu_correct can not be run.

@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #69 into master will decrease coverage by 6.67%.
The diff coverage is 13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   85.15%   78.48%   -6.68%     
==========================================
  Files          32       34       +2     
  Lines        1354     1464     +110     
  Branches      121      132      +11     
==========================================
- Hits         1153     1149       -4     
- Misses        164      278     +114     
  Partials       37       37
Impacted Files Coverage Δ
neurodocker/interfaces/__init__.py 100% <ø> (ø) ⬆️
neurodocker/reprozip/__init__.py 0% <0%> (ø)
neurodocker/reprozip/merge.py 0% <0%> (ø)
neurodocker/reprozip/trace.py 0% <0%> (ø)
neurodocker/neurodocker.py 89.69% <80%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f202d...ec60538. Read the comment docs.

@kaczmarj
Copy link
Collaborator Author

@schahid - can you please elaborate on your issue? are you using neurodocker to generate the freesurfer image? if so, can you share that command? you can submit a new issue and we can continue conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants