Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi export csv #518

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Multi export csv #518

merged 2 commits into from
Dec 21, 2020

Conversation

jasony123123
Copy link
Collaborator

Closes #515

To test:

  1. go to a drive or organization page
  2. export communities in both geojson and csv (i changed both functions bit)
  3. make sure both are correct and match up with the communities displayed on the webpage

@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #518 (23383a1) into staging (cfe8872) will increase coverage by 3.07%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #518      +/-   ##
===========================================
+ Coverage    69.49%   72.57%   +3.07%     
===========================================
  Files          105      105              
  Lines         2177     1907     -270     
===========================================
- Hits          1513     1384     -129     
+ Misses         664      523     -141     
Impacted Files Coverage Δ
main/urls.py 100.00% <ø> (ø)
main/views/partners.py 62.35% <36.84%> (-3.05%) ⬇️
main/views/main.py 29.79% <100.00%> (-3.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ac6c4...23383a1. Read the comment docs.

Copy link
Contributor

@k-y-le k-y-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jasony123123 jasony123123 merged commit 91589ef into staging Dec 21, 2020
@jasony123123 jasony123123 deleted the multi-export-csv branch December 21, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants