Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READLY-124 Add BOMs and clean up all dependencies #78

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

MatthewRyanRead
Copy link
Member

@MatthewRyanRead MatthewRyanRead commented Sep 29, 2023

  • Move all third-party dependency pins to alchemy-dependencies
  • Create alchemy-bom so other projects can just import it instead of pinning each Alchemy library
  • Remove Maven shading because it is increasing the artifact size and prevents appropriately overriding the dependency versions
  • Bump Dropwizard to the latest 1.3.x
  • Bump Jetty to the latest 9.4.x
  • Bump HK2 to the latest 2.5.x
  • Bump Guice to 5.1.0
  • Bump Guava to the latest version
  • Bump several minor dependencies
  • Use the BOMs provided by major dependencies, where available
  • Run dependency:analyze-only during the build and dependency-analyze on the PR check to ensure all dependencies are explicit
  • Replaced Findbugs/Checkstyle with Spotbugs
    • Not being enforced yet, since it has caught a lot more — it's just logging
  • Fix issues found by the newer EqualsVerifier
  • Replace Codahale (DW Metrics v3) with DW Metrics v4
  • Add Dependabot config

This was tested via a regression on our internal Alchemy service, with no issues found.

@MatthewRyanRead MatthewRyanRead added enhancement dependencies Pull requests that update a dependency file labels Sep 29, 2023
Copy link
Contributor

@rdlf0 rdlf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

.github/workflows/release.yml Show resolved Hide resolved
@MatthewRyanRead MatthewRyanRead merged commit e4fa762 into master Oct 4, 2023
@MatthewRyanRead MatthewRyanRead deleted the dependency-bumps branch October 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants