Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of override for destructors, make some destructors default, … #205

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

jwillemsen
Copy link
Member

…add std::move for poa constructor arguments

    * tests/poa/excessive_object_deactivations/excessive_object_deactivations.cpp:
    * tests/poa/excessive_object_deactivations/excessive_object_deactivations.cpp:
    * tests/hello_regen/test_impl.h:
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #205 (1b3fc9d) into master (32df096) will decrease coverage by 0.00%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   59.60%   59.60%   -0.01%     
==========================================
  Files         570      572       +2     
  Lines       47511    47515       +4     
  Branches     4186     4187       +1     
==========================================
+ Hits        28321    28322       +1     
- Misses      16119    16121       +2     
- Partials     3071     3072       +1     
Impacted Files Coverage Δ
tests/localinterface/locala.cpp 34.61% <0.00%> (-15.39%) ⬇️
tests/obv/supports/supports_test_impl.cpp 63.07% <ø> (-1.63%) ⬇️
...ts/pi/forward_request/server_request_interceptor.h 50.00% <0.00%> (ø)
tests/poa/poamanager/poamanager.cpp 64.61% <ø> (ø)
tests/policies/oneway_timeouts/server.cpp 66.46% <ø> (ø)
tests/factory/hello.cpp 100.00% <100.00%> (ø)
tests/factory/hello.h 100.00% <100.00%> (ø)
tests/interface/hello.cpp 73.86% <100.00%> (ø)
tests/is_equivalent/hello.cpp 69.09% <100.00%> (-1.09%) ⬇️
tests/is_equivalent/hello.h 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32df096...1b3fc9d. Read the comment docs.

@jwillemsen jwillemsen merged commit 82665f9 into RemedyIT:master Apr 1, 2022
@jwillemsen jwillemsen deleted the jwi-overridemove branch April 1, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant