refactor: move ramstk_load_history to sub-package

.github/trafico.yml

@@ -37,4 +37,4 @@ labels:
     name: "status: closed"
     color: "#0E8A16"
     description: "Pull Request is complete and integrated or closed for anther reason."
-    ignore: true
+    ignore: false

.github/workflows/do_release.yml

@@ -84,6 +84,7 @@ jobs:
           repository_url: https://test.pypi.org/legacy/
 
       - name: Test install from Test PyPI
+        if: ${{ env.build_ok == 1 }}
         run: |
           sudo apt-get update
           sudo apt-get install -y --no-install-recommends apt-utils git libgirepository1.0-dev gir1.2-gtk-3.0 python3-gi python3-gi-cairo python3-pytest libenchant1c2a libenchant-dev python3-numpy python3-scipy xauth xvfb

.github/workflows/dont-static-checks.yml

@@ -0,0 +1,53 @@
+# This is a dummy workflow that will run when the conditions of the
+# do-static-checks workflow aren't met.  This allows PRs to be merged when the
+# conditions aren't met for a protected branch.  See
+# https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks
+name: Perform Static Checks on RAMSTK Code Base
+
+on:
+  push:
+    paths-ignore:
+      - "**.py"
+  pull_request:
+    paths-ignore:
+      - "**.py"
+    types:
+      - "opened"
+      - "reopened"
+      - "synchronize"
+
+jobs:
+  bandit:
+    name: Check for Security Vulnerabilities
+    runs-on: ubuntu-latest
+    steps:
+      - run:
+          echo "No security check required."
+
+  format-check:
+    name: Check Code Formatting
+    runs-on: ubuntu-latest
+    steps:
+      - run:
+          echo "No files to be formatted."
+
+  style-check:
+    name: Check Code Styling
+    runs-on: ubuntu-latest
+    steps:
+      - run:
+          echo "No files to be style checked."
+
+  type-check:
+    name: Check Code Type Hinting
+    runs-on: ubuntu-latest
+    steps:
+      - run:
+          echo "No files to be type checked."
+
+  lint-check:
+    name: Check Code Lint
+    runs-on: ubuntu-latest
+    steps:
+      - run:
+          echo "No files to be linted."

.github/workflows/dont-test-suite.yml

@@ -0,0 +1,33 @@
+# This is a dummy workflow that will run when the conditions of the
+# do-test-suite workflow aren't met.  This allows PRs to be merged when the
+# conditions aren't met for a protected branch.  See
+# https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks
+name: Execute RAMSTK Test Suite with Coverage
+
+on:
+  push:
+    paths-ignore:
+      - "**.py"
+  pull_request:
+    paths-ignore:
+      - "**.py"
+    types:
+      - "opened"
+      - "reopened"
+      - "synchronize"
+
+jobs:
+  test_suite:
+    name: Run Test Suite
+    runs-on: ubuntu-latest
+    steps:
+      - run: |
+          echo "Test suite not required."
+
+  upload_coveralls:
+    name: Upload Results to Coveralls
+    needs: test_suite
+    runs-on: ubuntu-latest
+    steps:
+      - run: |
+          echo "No test suite required; no coverage report generated."

.github/workflows/on-pr-close.yml

@@ -1,9 +1,6 @@
 # This workflow runs when a pull request is closed.
 #
 # - Job 1:
-#     - Remove 'status: inprogress' label.
-#     - Add 'status: closed' label.
-# - Job 2:
 #     - Gets list of PR labels.
 #     - Get current version from VERSION.
 #     - Determine next Semantic version.
@@ -21,16 +18,6 @@ on:
       - closed
 
 jobs:
-  label-pr-closed:
-    name: Add Closed Label
-    runs-on: ubuntu-latest
-    steps:
-      - name: Add label
-        uses: andymckay/labeler@master
-        with:
-          add-labels: "status: closed"
-          remove-labels: "status: inprogress"
-
   tag-version:
     name: Push Version Tag
     runs-on: ubuntu-latest

.github/workflows/on-pr-merge.yml

@@ -64,12 +64,6 @@ jobs:
           make html
           cd ..
 
-      - name: Build pdf documentation
-        run: |
-          cd docs
-          make latexpdf LATEXMKOPTS="-silent -f"
-          cd ..
-
       - name: Import GPG key
         id: import_gpg
         uses: crazy-max/ghaction-import-gpg@v4
@@ -96,3 +90,9 @@ jobs:
           branch: gh-pages
           directory: gh-pages
           github_token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Build pdf documentation
+        run: |
+          cd docs
+          make latexpdf LATEXMKOPTS="-silent -f"
+          cd ..

pyproject.toml

@@ -216,7 +216,8 @@ disable = [
 	'fixme',
 	'anomalous-unicode-escape-in-string',
 	'import-error',
-	'no-member'
+	'no-member',
+	'no-else-return'
 ]
 
 [tool.pylint.reports]

src/ramstk/analyses/allocation.py

@@ -390,9 +390,8 @@ def get_allocation_goal(**attributes: Dict[str, Any]) -> Dict[str, Any]:
     :raise: KeyError if the passed attributes dict doesn't contain the
         allocation_method_id, hazard_rate_goal, and/or reliability_goal key.
     """
-    if attributes["allocation_method_id"] in [2, 4]:  # ARINC or FOO.
-        _goal = attributes["hazard_rate_goal"]
-    else:
-        _goal = attributes["reliability_goal"]
-
-    return _goal
+    return (
+        attributes["hazard_rate_goal"]
+        if attributes["allocation_method_id"] in [2, 4]
+        else attributes["reliability_goal"]
+    )

src/ramstk/analyses/criticality.py

@@ -40,14 +40,12 @@ def calculate_rpn(sod):
     if not 0 < sod["rpn_detection"] < 11:
         raise OutOfRangeError(("RPN detection is outside the range [1, 10]."))
 
-    _rpn = (
+    return (
         int(sod["rpn_severity"])
         * int(sod["rpn_occurrence"])
         * int(sod["rpn_detection"])
     )
 
-    return _rpn
-
 
 def calculate_mode_hazard_rate(item_hr, mode_ratio):
     """Calculate the failure mode hazard rate.

src/ramstk/analyses/fha.py

@@ -216,10 +216,9 @@ def set_user_defined_functions(
     for _idx in [6, 7, 8, 9, 10]:
         try:
             _key = list(fha.keys())[_idx]
-            if str(functions[_idx - 6]) == "":
-                fha[_key] = "0.0"
-            else:
-                fha[_key] = str(functions[_idx - 6])
+            fha[_key] = (
+                "0.0" if not str(functions[_idx - 6]) else str(functions[_idx - 6])
+            )
         except IndexError:
             fha[_key] = "0.0"
 

src/ramstk/analyses/milhdbk217f/milhdbk217f.py

@@ -230,18 +230,14 @@ def _get_environment_factor(
         10: {1: crystal.PI_E, 2: efilter.PI_E, 3: fuse.PI_E, 4: lamp.PI_E},
     }
 
-    if category_id == 8 and subcategory_id in [1, 2]:
-        _pi_e = _pi_e_lists[category_id][subcategory_id][quality_id][
+    if category_id == 8 and subcategory_id in {1, 2}:
+        return _pi_e_lists[category_id][subcategory_id][quality_id][
             environment_active_id - 1
         ]
-    elif category_id in [2, 3, 5, 7, 9, 10] or (
-        category_id == 8 and subcategory_id not in [1, 2]
-    ):
-        _pi_e = _pi_e_lists[category_id][subcategory_id][environment_active_id - 1]
+    elif category_id in {2, 3, 5, 7, 9, 10, 8}:
+        return _pi_e_lists[category_id][subcategory_id][environment_active_id - 1]
     else:
-        _pi_e = _pi_e_lists[category_id][environment_active_id - 1]
-
-    return _pi_e
+        return _pi_e_lists[category_id][environment_active_id - 1]
 
 
 def _get_part_count_quality_factor(
@@ -276,18 +272,17 @@ def _get_part_count_quality_factor(
         10: {1: crystal.PART_COUNT_PI_Q, 2: efilter.PI_Q},
     }
 
-    if category_id in [6, 7, 9]:
-        _pi_q = _pi_q_lists[category_id][subcategory_id][quality_id - 1]
-    elif category_id == 10 and subcategory_id in [1, 2]:
-        _pi_q = _pi_q_lists[category_id][subcategory_id][quality_id - 1]
-    elif category_id == 10 and subcategory_id in [3, 4]:
-        _pi_q = 1.0
+    if category_id in {6, 7, 9}:
+        return _pi_q_lists[category_id][subcategory_id][quality_id - 1]
+    elif category_id == 10 and subcategory_id in {1, 2}:
+        return _pi_q_lists[category_id][subcategory_id][quality_id - 1]
+    elif category_id == 10 and subcategory_id in {3, 4}:
+        return 1.0
     else:
-        _pi_q = _pi_q_lists[category_id][quality_id - 1]
-
-    return _pi_q
+        return _pi_q_lists[category_id][quality_id - 1]
 
 
+# pylint: disable=too-many-return-statements
 def _get_part_stress_quality_factor(
     category_id: int, subcategory_id: int, quality_id: int
 ) -> float:
@@ -315,20 +310,20 @@ def _get_part_stress_quality_factor(
     }
 
     if category_id == 1:
-        _pi_q = _pi_q_lists[category_id][quality_id - 1]
-    elif (category_id == 8 and subcategory_id in [4, 5]) or (
-        category_id == 7 and subcategory_id == 5
+        return _pi_q_lists[category_id][quality_id - 1]
+    elif (
+        category_id == 8
+        and subcategory_id in {4, 5}
+        or (category_id == 7 and subcategory_id == 5)
     ):
-        _pi_q = _pi_q_lists[category_id][subcategory_id][quality_id - 1]
-    elif category_id == 7 and subcategory_id != 5:
-        _pi_q = 0.0
-    elif category_id == 8 and subcategory_id not in [4, 5]:
-        _pi_q = 0.0
+        return _pi_q_lists[category_id][subcategory_id][quality_id - 1]
+    elif category_id == 7:
+        return 0.0
+    elif category_id == 8:
+        return 0.0
     elif category_id == 9 and subcategory_id == 1:
-        _pi_q = 0.0
-    elif category_id == 10 and subcategory_id in [3, 4]:
-        _pi_q = 0.0
+        return 0.0
+    elif category_id == 10 and subcategory_id in {3, 4}:
+        return 0.0
     else:
-        _pi_q = _pi_q_lists[category_id][subcategory_id][quality_id - 1]
-
-    return _pi_q
+        return _pi_q_lists[category_id][subcategory_id][quality_id - 1]

src/ramstk/analyses/milhdbk217f/models/capacitor.py

@@ -420,9 +420,7 @@ def calculate_capacitance_factor(subcategory_id: int, capacitance: float) -> flo
     }
     _f0 = _dic_factors[subcategory_id][0]
     _f1 = _dic_factors[subcategory_id][1]
-    _pi_cv = _f0 * capacitance ** _f1
-
-    return _pi_cv
+    return _f0 * capacitance ** _f1
 
 
 def calculate_part_count(**attributes: Dict[str, Any]) -> float:
@@ -549,14 +547,12 @@ def calculate_part_stress_lambda_b(
     _f2 = _dic_factors[subcategory_id][2]
     _f3 = _dic_factors[subcategory_id][3]
     _f4 = _dic_factors[subcategory_id][4]
-    _lambda_b = (
+    return (
         _f0
         * ((voltage_ratio / _f1) ** _f2 + 1.0)
         * exp(_f3 * ((temperature_active + 273.0) / _ref_temp) ** _f4)
     )
 
-    return _lambda_b
-
 
 def calculate_series_resistance_factor(
     resistance: float, voltage_dc_operating: float, voltage_ac_operating: float
@@ -576,19 +572,17 @@ def calculate_series_resistance_factor(
     _ckt_resistance = resistance / (voltage_dc_operating + voltage_ac_operating)
 
     if 0 < _ckt_resistance <= 0.1:
-        _pi_sr = 0.33
+        return 0.33
     elif 0.1 < _ckt_resistance <= 0.2:
-        _pi_sr = 0.27
+        return 0.27
     elif 0.2 < _ckt_resistance <= 0.4:
-        _pi_sr = 0.2
+        return 0.2
     elif 0.4 < _ckt_resistance <= 0.6:
-        _pi_sr = 0.13
+        return 0.13
     elif 0.6 < _ckt_resistance <= 0.8:
-        _pi_sr = 0.1
+        return 0.1
     else:
-        _pi_sr = 0.066
-
-    return _pi_sr
+        return 0.066
 
 
 def get_configuration_factor(configuration_id: int) -> float:
@@ -696,13 +690,12 @@ def get_part_count_lambda_b(
     :rtype: float
     :raise: KeyError if passed an unknown subcategory ID or specification ID.
     """
-    if subcategory_id == 1:
-        _base_hr = PART_COUNT_LAMBDA_B[subcategory_id][  # type: ignore
-            specification_id
-        ][environment_active_id - 1]
-    else:
-        _base_hr = PART_COUNT_LAMBDA_B[subcategory_id][  # type: ignore
+    return (
+        PART_COUNT_LAMBDA_B[subcategory_id][specification_id][  # type: ignore
             environment_active_id - 1
         ]
-
-    return _base_hr
+        if subcategory_id == 1
+        else PART_COUNT_LAMBDA_B[subcategory_id][  # type: ignore
+            environment_active_id - 1
+        ]
+    )