Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport for 0.1 release: Don't use Pkg to compute project-version. #115

Merged
merged 2 commits into from
May 26, 2023

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented May 25, 2023

This feature from Pkg is apparently "experimental" and not well supported, so it's safer to just read from the TOML file ourselves.

Also, TOML is a much smaller dependency than Pkg.
Backports #114.

NHDaly added 2 commits May 25, 2023 11:26
This feature from Pkg is apparently "experimental" and not well supported,
so it's safer to just read from the TOML file ourselves.

Also, TOML is a much smaller dependency than Pkg.
@NHDaly NHDaly requested review from msagarpatel and removed request for msagarpatel May 25, 2023 17:29
@NHDaly NHDaly merged commit a90aa12 into release-0.1 May 26, 2023
@NHDaly NHDaly deleted the nhd-v0.1-user-agent branch May 26, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant