Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export cancel_transaction #107

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: export cancel_transaction #107

merged 1 commit into from
Feb 21, 2023

Conversation

mcmcgrath13
Copy link
Contributor

Going through the sdk docs, it seems like cancel_transaction ought to be exported. This PR does that.

https://docs.relational.ai/rkgms/sdk/julia-sdk#transaction-cancellation

@mcmcgrath13 mcmcgrath13 requested a review from NHDaly February 14, 2023 21:31
@NHDaly NHDaly requested a review from NRHelmi February 15, 2023 06:20
@mcmcgrath13
Copy link
Contributor Author

@NRHelmi are you okay with merging this?

@NRHelmi
Copy link
Contributor

NRHelmi commented Feb 21, 2023

thanks @mcmcgrath13

@NHDaly NHDaly merged commit 1e5103c into main Feb 21, 2023
@NHDaly NHDaly deleted the mcm-export-cancel-tx branch February 21, 2023 20:12
@NHDaly
Copy link
Member

NHDaly commented Feb 21, 2023

(feel free to make a release if you want to; i think you should have permissions. Otherwise i would probably wait til another PR or two, just cause it's tedious)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants