Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel builds with GNU make #53

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

joseeroman
Copy link
Contributor

@joseeroman joseeroman commented Mar 6, 2022

In order for make -j to work correctly, the BLACS library should be built before the other libraries. This can be achieved with an explicit dependency.

Also, the child make processes must be launched with $(MAKE) so that the -j option is propagated correctly.

@weslleyspereira
Copy link
Collaborator

Thanks for highlighting this issue! I think a better fix would be to make sure all dependencies on BLACS are well established on the Makefile. What do you think?

@joseeroman
Copy link
Contributor Author

Yes, that could be an alternative solution. I proposed this solution because I am not sure if BLACS is the only dependency or there are other dependencies between the prerequisites of the lib target. You know better than me.

In order for `make -j` to work correctly, the BLACS library should be
built before the other libraries. This can be achieved with an explicit
dependency.

Also, the child make processes must be launched with `$(MAKE)` so that
the `-j` option is propagated correctly.
@joseeroman joseeroman force-pushed the jose/parallel-make branch from 97c3171 to 6e58144 Compare March 7, 2022 09:01
@joseeroman
Copy link
Contributor Author

I have modified the commit. Assuming that BLACS is the only dependency, the new version should work equally well, and does not contain any GNU-specific keywords.

@joseeroman
Copy link
Contributor Author

Note that the current version fixes make -j lib but not the all target. The previous solution was good for both. To me, this is not important.

@weslleyspereira
Copy link
Collaborator

Thanks! Even if it does not solve the whole problem with the dependencies, I believe this is the right way to go.

Since those changes solve your problem, I will approve this PR. I will open a new issue so as we do not forget to fix the dependencies.

Thanks!

@langou langou merged commit 5e38ec4 into Reference-ScaLAPACK:master Mar 7, 2022
@prj- prj- mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants