Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests and message interface #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

acurrieclark
Copy link

Purely to illustrate what I had in mind and to see what you think. I am aware that this is very much a breaking change from your code.

Any feedback would be gratefully received.

Introduced a message object which formats the request properly for android and ios
updated readme
@jrhenderson1988
Copy link
Contributor

Hi @acurrieclark - Thank you for the pull request. We really appreciate all the effort you've put into it and we love the direction you've taken. We would like to get this merged into the project, however at the moment we're looking to support PHP 7.0 and above. Some of the code you've submitted looks like it would only be supported by 7.1 and above, particularly the use of nullable types in places. If you would be able to make adjustments to support 7.0 we would definitely look to get your pull request merged in. Thank you for your effort.

@acurrieclark
Copy link
Author

Good point. I will look into that and adjust. Thanks for having a look.

@acurrieclark
Copy link
Author

I have updated this to reflect requirements for PHP 7.0, although I do not have it running on my local dev setup. The test all pass on Travis CI for both 7.0 and 7.1 , and I have introduced a Travis config file if you wanted to set that up on the root repo too?

As an aside, the message structure which is generated for iOS and Android is the structure which has worked for me in the past and which works well in all my tests. All the apps I have tested with are Cordova base, working with the Phonegap Push Plugin. It might be worthwhile, if you have access to one, testing it with a few other apps.

Also, I haven't documented the Message class yet. Will do if I have time, but for now i think this pull request is ready.

Thanks for letting me contribute.

@mforcer
Copy link
Contributor

mforcer commented Nov 2, 2017

Thanks for the update @acurrieclark will review/test asap and get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants