Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wildcards on Windows (Issue: #1521) #1522

Merged
merged 6 commits into from
Apr 23, 2024
Merged

fix: wildcards on Windows (Issue: #1521) #1522

merged 6 commits into from
Apr 23, 2024

Conversation

dmitri-trofimov
Copy link
Contributor

@dmitri-trofimov dmitri-trofimov commented Apr 10, 2024 •
edited
Loading

What/Why/How?

This PR fixes and issue with handling wildcards in command-line on Windows (#1521).

Testing

Tested locally on my machine.

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@dmitri-trofimov dmitri-trofimov requested a review from a team as a code owner April 10, 2024 11:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: dad951d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dmitri-trofimov dmitri-trofimov requested a review from a team as a code owner April 10, 2024 11:58
@dmitri-trofimov dmitri-trofimov changed the title fix #1521: wildcards on Windows fix: wildcards on Windows (#1521) Apr 10, 2024
@dmitri-trofimov dmitri-trofimov changed the title fix: wildcards on Windows (#1521) fix: wildcards on Windows (Issue: #1521) Apr 10, 2024
@lornajane
Copy link
Contributor

This looks great, thanks @dmitri-trofimov

tatomyr
tatomyr approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The changes will be available in the next release.

@tatomyr tatomyr merged commit 89af9c6 into Redocly:main Apr 23, 2024
28 checks passed
@dmitri-trofimov
Copy link
Contributor Author

Thank you so much!

@dmitri-trofimov dmitri-trofimov deleted the #1521-fix-wildcards-on-windows branch April 24, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatomyr tatomyr tatomyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitri-trofimov @lornajane @tatomyr