Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scale sideMenu labels according to computed font size #1356

Merged
merged 2 commits into from
Aug 20, 2020
Merged

fix: scale sideMenu labels according to computed font size #1356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a7deec
fix: scale sideMenu labels according to computed font size
wopian Aug 19, 2020
b5b123d
fix: ensure browser falls back to a sans-serif font
wopian Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/SideMenu/styled.elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import styled, { css, ResolvedThemeInterface } from '../../styled-components';
export const OperationBadge = styled.span.attrs((props: { type: string }) => ({
className: `operation-type ${props.type}`,
}))<{ type: string }>`
width: 32px;
width: 9ex;
display: inline-block;
height: ${props => props.theme.typography.code.fontSize};
line-height: ${props => props.theme.typography.code.fontSize};
Expand All @@ -16,7 +16,7 @@ export const OperationBadge = styled.span.attrs((props: { type: string }) => ({
background-repeat: no-repeat;
background-position: 6px 4px;
font-size: 7px;
font-family: Verdana; // web-safe
font-family: Verdana, sans-serif; // web-safe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is important!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what it looks like for me without it:

image

color: white;
text-transform: uppercase;
text-align: center;
Expand Down