Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add debounce for 300 ms when searching #1089

Merged
merged 3 commits into from
Mar 16, 2020
Merged

fix: Add debounce for 300 ms when searching #1089

merged 3 commits into from
Mar 16, 2020

Conversation

faheem00
Copy link
Contributor

Fixes #1027

Steps taken

  • Ran tslint
  • Ran all tests
  • Ran yarn prettier

@faheem00
Copy link
Contributor Author

faheem00 commented Oct 29, 2019 •
edited
Loading

Search should support arrow navigation test seems to be failing. Is it because the search result function was debounced, and the result display is delayed?

EDIT: I tried the test using the latest master commit, and it's failing there as well.

@fabienpomerol
Copy link

@faheem00 guys any update on this subject ? i'm also interested by the fix :)

@RomanHotsiy RomanHotsiy changed the title Add debounce for 300 ms when searching fix: Add debounce for 300 ms when searching Mar 16, 2020
@RomanHotsiy RomanHotsiy merged commit 373f018 into Redocly:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy requested changes

@MIKE199512031995 MIKE199512031995 MIKE199512031995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching bogs down while typing a search term
4 participants
@faheem00 @fabienpomerol @RomanHotsiy @MIKE199512031995