Skip to content

Commit

Permalink
tiare: camera: Drop usage of LOCAL_COPY_HEADERS
Browse files Browse the repository at this point in the history
Google deprecated LOCAL_COPY_HEADERS in Android 11,
so use LOCAL_EXPORT_C_INCLUDE_DIRS instead.

Ref: https://android.googlesource.com/platform/build/soong/+/master/docs/best_practices.md#headers.

 Conflicts:
	camera/QCamera2/stack/mm-camera-interface/Android.mk

Signed-off-by: Ali Hasan <ahb7671@gmail.com>
Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
  • Loading branch information
bgcngm authored and techyminati committed Apr 12, 2022
1 parent da5f11f commit 7401aea
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 6 additions & 4 deletions camera/QCamera2/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ LOCAL_PATH:= $(call my-dir)

include $(CLEAR_VARS)

LOCAL_COPY_HEADERS_TO := qcom/camera
LOCAL_COPY_HEADERS := QCameraFormat.h

LOCAL_SRC_FILES := \
util/QCameraBufferMaps.cpp \
util/QCameraCmdThread.cpp \
Expand Down Expand Up @@ -84,7 +81,6 @@ LOCAL_C_INCLUDES := \
$(LOCAL_PATH)/../mm-image-codec/qexif \
$(LOCAL_PATH)/../mm-image-codec/qomx_core \
$(LOCAL_PATH)/include \
$(LOCAL_PATH)/stack/common \
$(LOCAL_PATH)/stack/mm-camera-interface/inc \
$(LOCAL_PATH)/util \
$(LOCAL_PATH)/HAL3 \
Expand All @@ -97,6 +93,7 @@ LOCAL_HEADER_LIBRARIES += libandroid_sensor_headers
LOCAL_HEADER_LIBRARIES += libcutils_headers
LOCAL_HEADER_LIBRARIES += libsystem_headers
LOCAL_HEADER_LIBRARIES += libhardware_headers
LOCAL_HEADER_LIBRARIES += camera_common_headers

#HAL 1.0 Include paths
LOCAL_C_INCLUDES += \
Expand Down Expand Up @@ -146,5 +143,10 @@ LOCAL_MODULE_TAGS := optional
LOCAL_32_BIT_ONLY := $(BOARD_QTI_CAMERA_32BIT_ONLY)
include $(BUILD_SHARED_LIBRARY)

include $(CLEAR_VARS)
LOCAL_MODULE := camera_common_headers
LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/stack/common
include $(BUILD_HEADER_LIBRARY)

include $(call first-makefiles-under,$(LOCAL_PATH))
endif
File renamed without changes.
4 changes: 1 addition & 3 deletions camera/QCamera2/stack/mm-camera-interface/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ include $(CLEAR_VARS)

LOCAL_HEADER_LIBRARIES := libhardware_headers
LOCAL_HEADER_LIBRARIES += media_plugin_headers
LOCAL_HEADER_LIBRARIES += camera_common_headers

MM_CAM_FILES := \
src/mm_camera_interface.c \
Expand Down Expand Up @@ -36,9 +37,6 @@ ifneq (,$(filter msm8996 msmcobalt msmfalcon,$(TARGET_BOARD_PLATFORM)))
endif

LOCAL_CFLAGS += -D_ANDROID_ -DQCAMERA_REDEFINE_LOG
LOCAL_COPY_HEADERS_TO := mm-camera-interface
LOCAL_COPY_HEADERS += ../common/cam_intf.h
LOCAL_COPY_HEADERS += ../common/cam_types.h

LOCAL_C_INCLUDES := \
$(LOCAL_PATH)/inc \
Expand Down

0 comments on commit 7401aea

Please sign in to comment.