Skip to content

Commit

Permalink
Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnSharpe committed Jul 13, 2023
1 parent 56b3867 commit 91a73be
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions provider/resource_rediscloud_acl_role.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ func resourceRedisCloudAclRole() *schema.Resource {
DeleteContext: resourceRedisCloudAclRoleDelete,

Importer: &schema.ResourceImporter{
// Let the READ operation do the heavy lifting for importing values from the API.
StateContext: schema.ImportStatePassthroughContext,
},

Expand All @@ -35,7 +34,7 @@ func resourceRedisCloudAclRole() *schema.Resource {

Schema: map[string]*schema.Schema{
"name": {
Description: "A meaningful name to identify the role",
Description: "A meaningful name to identify the role, must be unique",
Type: schema.TypeString,
Required: true,
},
Expand Down Expand Up @@ -201,7 +200,7 @@ func resourceRedisCloudAclRoleDelete(ctx context.Context, d *schema.ResourceData
return retry.RetryableError(fmt.Errorf("expected role %d to be deleted but was in state %s", id, redis.StringValue(role.Status)))
}
// Unclear at this point what's going on!
return retry.NonRetryableError(fmt.Errorf("unexpectederror getting role"))
return retry.NonRetryableError(fmt.Errorf("unexpected error getting role"))
})
if err != nil {
return diag.FromErr(err)
Expand Down
3 changes: 1 addition & 2 deletions provider/resource_rediscloud_acl_rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ func resourceRedisCloudAclRule() *schema.Resource {
DeleteContext: resourceRedisCloudAclRuleDelete,

Importer: &schema.ResourceImporter{
// Let the READ operation do the heavy lifting for importing values from the API.
StateContext: schema.ImportStatePassthroughContext,
},

Expand All @@ -35,7 +34,7 @@ func resourceRedisCloudAclRule() *schema.Resource {

Schema: map[string]*schema.Schema{
"name": {
Description: "A meaningful name to identify the rule. Must be unique.",
Description: "A meaningful name to identify the rule, must be unique",
Type: schema.TypeString,
Required: true,
},
Expand Down

0 comments on commit 91a73be

Please sign in to comment.