Skip to content

Conversation

alonre24
Copy link
Collaborator

Fix bug in DAG reply for ai.tensorget op when the op was not executed due to an error that occurred beforehand. In this case we should return immediately return 'NA'.

@alonre24 alonre24 requested a review from DvirDukhan June 20, 2021 10:14
@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #793 (ce2402a) into master (0000228) will increase coverage by 6.29%.
The diff coverage is 81.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   74.11%   80.41%   +6.29%     
==========================================
  Files          39       52      +13     
  Lines        6081     7888    +1807     
==========================================
+ Hits         4507     6343    +1836     
+ Misses       1574     1545      -29     
Impacted Files Coverage Δ
src/redis_ai_types/model_type.c 70.00% <ø> (ø)
src/redis_ai_types/script_type.c 70.00% <ø> (+5.00%) ⬆️
src/redis_ai_types/tensor_type.c 73.33% <ø> (ø)
src/serialization/AOF/rai_aof_rewrite.c 0.00% <0.00%> (ø)
tests/module/DAG_utils.c 88.23% <ø> (ø)
tests/module/LLAPI.c 74.46% <ø> (ø)
tests/unit/rmalloc.h 100.00% <ø> (ø)
tests/unit/unit_tests_err.cpp 100.00% <ø> (ø)
src/backends/libtflite_c/tflite_c.cpp 57.60% <35.71%> (ø)
src/backends/tflite.c 66.01% <57.14%> (+2.19%) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ad9d8...ce2402a. Read the comment docs.

DvirDukhan
DvirDukhan previously approved these changes Jun 20, 2021
DvirDukhan
DvirDukhan previously approved these changes Jun 20, 2021
@alonre24 alonre24 added ci-test and removed ci-test labels Jun 24, 2021
@alonre24 alonre24 merged commit ccdc5e8 into master Jun 24, 2021
@alonre24 alonre24 deleted the Fix_dag_tensorget_reply branch June 24, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants