feat: make new questions translatable

RedTurtle · Jul 17, 2024 · 7b3b222 · 7b3b222
1 parent e29a76b
commit 7b3b222
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 18 deletions.
diff --git a/src/helpers/index.js b/src/helpers/index.js
@@ -1,7 +1,23 @@
 import config from '@plone/volto/registry';
 import { defineMessages } from 'react-intl';
 
-const messages = defineMessages({
+export const FEEDBACK_THRESHOLD = 3.5;
+export const NEGATIVE_FEEDBACK_QUESTIONS = [
+  'unclear_instructions',
+  'incomplete_instructions',
+  'unclear_proceeding',
+  'technical_problems',
+  'other_negative',
+];
+export const POSITIVE_FEEDBACK_QUESTIONS = [
+  'clear_instructions',
+  'complete_instructions',
+  'clear_proceeding',
+  'no_technical_problems',
+  'other_positive',
+];
+
+export const FEEDBACK_MESSAGES = defineMessages({
   unclear_instructions: {
     id: 'feedback_unclear_instructions',
     defaultMessage: 'Some instructions were not clear and confusing',
@@ -73,7 +89,9 @@ export const getTranslatedQuestion = (intl, question_id) => {
   if (!intl) throw new Error('No intl provided');
   if (!question_id) return null;
   try {
-    return intl.formatMessage(messages[question_id]);
+    return intl.formatMessage(
+      config.settings['volto-feedback'].questions.messages[question_id],
+    );
   } catch (e) {
     throw new Error(
       `Cannot translate ${question_id}, no linked translation exists for given parameter`,
@@ -101,19 +119,3 @@ export const generateFeedbackCommentUUID = (date) => {
   // the backend addon work.
   return new Date(date).getTime().toString(36);
 };
-
-export const NEGATIVE_FEEDBACK_QUESTIONS = [
-  'unclear_instructions',
-  'incomplete_instructions',
-  'unclear_proceeding',
-  'technical_problems',
-  'other_negative',
-];
-export const POSITIVE_FEEDBACK_QUESTIONS = [
-  'clear_instructions',
-  'complete_instructions',
-  'clear_proceeding',
-  'no_technical_problems',
-  'other_positive',
-];
-export const FEEDBACK_THRESHOLD = 3.5;
diff --git a/src/index.js b/src/index.js
@@ -13,6 +13,7 @@ import {
   NEGATIVE_FEEDBACK_QUESTIONS,
   POSITIVE_FEEDBACK_QUESTIONS,
   FEEDBACK_THRESHOLD,
+  FEEDBACK_MESSAGES,
 } from 'volto-feedback/helpers';
 
 export {
@@ -77,6 +78,7 @@ export default function applyConfig(config) {
     questions: {
       negativeFeedback: NEGATIVE_FEEDBACK_QUESTIONS,
       positiveFeedback: POSITIVE_FEEDBACK_QUESTIONS,
+      messages: FEEDBACK_MESSAGES,
     },
 
     formSteps: [