Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for exporting colors from variables #236

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Add support for exporting colors from variables #236

merged 8 commits into from
Apr 8, 2024

Conversation

alexey1312
Copy link
Contributor

@alexey1312 alexey1312 commented Apr 3, 2024 •
edited
Loading

  • Added ColorsVariablesLoader
  • Updated doc

Scheme

CleanShot 2024-04-04 at 08 12 40@2x

From the documentation:

  1. tokensCollectionName - the name of the variable collection
  2. lightModeName - the name of the color variable column for the light theme
  3. darkModeName - the name of the color variable column for the dark theme
  4. lightHCModeName - the name of the color variable column for the light theme with high contrast
  5. darkHCModeName - the name of the color variable column for the dark theme with high contrast
  6. A variable that has a local value
  7. A variable that refers to another variable in a different file
  1. primitivesModeName - the name of the variable column, if the value in CONFIG.md is not specified, the default value will be used
  2. A variable that has a local value

fyi:
#217

@alexey1312
Add VariablesEndpoint
4203542 
Add Variables models
@alexey1312
Add new VariablesColors params
bb5d949
@alexey1312
Add raw ColorsVariablesLoader
45960ad 
Update ExportColors

Update params name

Update params name

Small refactoring

Small refactoring

Add doc

Refactoring

Refactoring
@alexey1312
Update doc
4b0b888
@alexey1312
Filter support
c635b32
@alexey1312
Simplified handleColorMode method
488a2bd
@alexey1312
Small refactoring
f823e55
subdan
subdan requested changes Apr 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sources/FigmaExport/Subcommands/ExportColors.swift Outdated Show resolved Hide resolved
Sources/FigmaExport/Subcommands/ExportColors.swift Outdated Show resolved Hide resolved
Sources/FigmaAPI/Model/Variables.swift Outdated Show resolved Hide resolved
Sources/FigmaAPI/Model/Variables.swift Show resolved Hide resolved
Sources/FigmaAPI/Model/Variables.swift Outdated Show resolved Hide resolved
Sources/FigmaAPI/Model/Variables.swift Outdated Show resolved Hide resolved
@alexey1312 alexey1312 requested a review from subdan April 8, 2024 03:37
@subdan subdan merged commit d667c99 into RedMadRobot:master Apr 8, 2024
2 of 3 checks passed
@alexey1312 alexey1312 deleted the feature/variablesColors branch April 8, 2024 18:08
@subdan subdan mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subdan subdan subdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexey1312 @subdan