Image removal for azure and aws #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhil-jha
changed the title
akhil-jha
force-pushed
the
add_image_removal
branch
from
afdbd59
to
61d4496
Compare
2 tasks
mshriver
reviewed
Jul 10, 2023
akhil-jha
force-pushed
the
add_image_removal
branch
2 times, most recently
from
5d708eb
to
51b32f2
Compare
ogajduse
reviewed
Jul 26, 2023
akhil-jha
force-pushed
the
add_image_removal
branch
from
51b32f2
to
63499f9
Compare
ogajduse
reviewed
Jul 31, 2023
jyejare
requested changes
Aug 2, 2023
wrapanapi/systems/msazure.py
Outdated
| @@ -1130,6 +1166,21 @@ def delete_stack_by_date(self, days_old, resource_group=None): | |||
| result) | |||
| return results | |||
|
|
|||
| def delete_compute_image_using_name(self, resource_group=None, image_list=None): | |||
There was a problem hiding this comment.
Instead this should be delete images same as you have in EC2 systems. We cannot say by name becuase we are not passing as parameter name , we are just passing image_list be its all free images list or list of all images !
There was a problem hiding this comment.
Changed the name to delete_compute_image_by_resource_group(). Having "resource_group" becomes explicit which I think it fine.
akhil-jha
force-pushed
the
add_image_removal
branch
from
63499f9
to
04462a9
Compare
ogajduse
approved these changes
Aug 3, 2023
jyejare
approved these changes
Aug 7, 2023
mshriver
reviewed
Aug 7, 2023
| free_images = [] | ||
| vm_list = self.list_vms() | ||
|
|
||
| if not vm_list: |
There was a problem hiding this comment.
This block is unnecessary and repetitive.
for vm in vm_list:
free_images.append()
return free_images
This loop will noop when vm_list is an empty list, which the function is written to return.
mshriver
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.