[RFR][VirtualCenter] Added method set hot add for cpu and memory #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izapolsk
suggested changes
Mar 19, 2019
There was a problem hiding this comment.
looks good at first sight but I'd like you to do some changes.
Besides I suppose you're going to use these new methods in tests, right ? So, please create appropriate PR which uses this PR. You just need to temporarily update requirements to refer to your repo and branch. This will facilitate quicker review since we won't need to pull your PR and test it locally.
digitronik
changed the title
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
digitronik
changed the title
|
@niyazRedhat can you please add test related to changes?. If you need help let me know. |
|
@digitronik Sure |
mshriver
reviewed
Mar 22, 2019
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
mshriver
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikhil Dhandre ndhandre@redhat.com