-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding CLI argument option to specify location of settings.yaml #79
Conversation
Hello @bovem , Is it up for review ? |
Hi @jyejare sorry for the late reply currently I am occupied with some high priority tasks. I also wanted to ask that if I am correct the settings file path is currently passed using this method, but if I have passed it as a command line argument then do I have to explicitly define it for individual provider? |
@bovem For now, there is no way of passing the provider-specific settings/file. The method is currently focuses on settings as a whole and for all providers and in case if the settings are not found there then it goes to https://github.com/RedHatQE/cloudwash/tree/master/conf that has dedicated conf file for all computes. BTW we have a new PR opened as #81 to support multiple accounts and now its time to decide whats the definative way we should go to support multiple accounts. I would like to hear from you !! |
Ping @bovem :) |
Hi, @jyejare |
@bovem Thanks, I really missed the last comment. Lets setup a meeting next week to talk about that refactor. |
@bovem Looks like you need to rebase as the commit history contains the old commits in this PR. |
I see, I did a merge with the master branch of |
Yes @bovem ! |
3fcc3c0
to
18dd7b9
Compare
Hello @bovem When are you resuming the work. We need not to block this for architectural change to be made as its more of CLI change than an internal. Could you relook into it and we can get it merged ! |
Ping @bovem again !!! |
18dd7b9
to
fb78112
Compare
@jyejare I am sorry I think the PR got closed automatically because I forced pushed some changes to sync it with upstream. I'll raise a new PR with changes. |
Created for the resolution of issue: #45
Signed by: apal@redhat.com