Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] VMWare cleanup alignment with Develop branch #146

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

jyejare
Copy link
Collaborator

@jyejare jyejare commented Oct 25, 2024

The PR includes:

  • No new changes but the realignment of VMWare cleanup with develop branch

@jyejare jyejare changed the title VMWare cleanup alignment with Develop branch [Develop] VMWare cleanup alignment with Develop branch Oct 25, 2024
cloudwash/cli.py Outdated Show resolved Hide resolved
cloudwash/cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM

Tested the changes on latest vCenter8 ✅

➜  cloudwash git:(develop) ✗ swach --dry vmware --vms

<<<<<<< Running the cleanup script in DRY mode >>>>>>>
The VMWARE providers settings are initialized and validated !

=========== DRY SUMMARY ============

VMS:
	Deletable: ['test_vm_gtalreja']
	Skipped: ['automation-robottelo-vmware-vm', 'VMware vCenter Server']

====================================
➜  cloudwash git:(develop) ✗ swach vmware --vms

<<<<<<< Running the cleanup script in ACTION mode >>>>>>>
The VMWARE providers settings are initialized and validated !
Removed VMs:
['test_vm_gtalreja']
Skipped VMs:
['automation-robottelo-vmware-vm', 'VMware vCenter Server']

@jyejare jyejare merged commit bf9e8c4 into RedHatQE:develop Oct 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants