Add support for collecting deletable OCP leftovers from AWS #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #481 |
|
/verified |
omkarkhatavkar
approved these changes
Jun 12, 2024
Co-authored-by: Jitendra Yejare <jyejare@redhat.com>
…ist_ocp_resources
…o list_ocp_resources
|
/verified |
jyejare
approved these changes
Jun 19, 2024
|
@oharan2 Could you paste some logs that cleaned up OCP resources from AWS from multiple regions. |
|
/verified |
jyejare
requested changes
Jun 20, 2024
cloudwash/providers/aws.py
Outdated
| if filtered_leftovers: | ||
| dry_data["OCPS"]["delete"].extend(filtered_leftovers) | ||
| # Print cluster_name only if it's resources are deletable | ||
| dry_data["OCPS"]["clusters"].extend([cluster_name]) |
There was a problem hiding this comment.
Ahh! not something we are looking for adding into the list of clusters.
Still if you want to print the clusters, You could add that to the line saying:
Resources from the region: us-east-1
as
Resources from the region: us-east-1 and clusters: 'ods-qe-aws-01-pool-zn-qdns7', 'testgsno-pool-shph9-pcbfk'
There was a problem hiding this comment.
Reverted, will be resolved in the OCP resources deletion PR (WIP)
This reverts commit f6dc711.
jyejare
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main flow:
Fetching OCP resources using RedHatQe/wrapnapi
Filtering resources using the
kubernetes.io/cluster/*tag regexResources without associated EC2 Instances considered as leftovers
Resources associated with EC2 Instances are filtered by their EC2 Instances time modified
For simplicity- deletion process will be separated by a following PR