Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a block for how to run the cloudwash setup locally #124

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mayurilahane
Copy link
Contributor

No description provided.

@mayurilahane mayurilahane force-pushed the mlahane/clouwash_readme branch from c73a348 to 1445793 Compare January 10, 2024 20:01
Copy link
Contributor

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mayurilahane!

@mayurilahane mayurilahane force-pushed the mlahane/clouwash_readme branch from 1445793 to d08114c Compare January 15, 2024 20:17
README.md Outdated
azure_tenant_id: "XXXXXXXXX"
subscription_id: "XXXXXXXXX"
```
* You will also need to update the bonfire config.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mshriver,
After you approved this MR I remembered I had made some changes in the bonfire local config too.
So, can you please review if it's required or not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider actually dropping this bonfire section, focusing on the minikube setup? IIRC there are issues with permissions in the ephemeral namespaces? I don't recall specific modifications made - because I think we ended up just using minikube to create the resources and pod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right !!
I wasn't sure about it!
anyways i just removed it
@jyejare can you please merge it ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPs I did not notice the ping. Merging.

@mayurilahane mayurilahane force-pushed the mlahane/clouwash_readme branch from d08114c to 2256530 Compare January 16, 2024 20:19
Copy link
Collaborator

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response. But we should add a new docs directory and add a new doc there mentioning everything in this PR and finally just provide the source reference to the README doc.

README.md Outdated
@@ -172,3 +171,162 @@ Removed following and all unused discs from Azure Cloud.
Removed following and all unused pips from Azure Cloud.
['test-axodawttrw-pip0']
```
# How to run the cloudwash setup locally
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a separate doc for this and refer the document source in README. This would be a very big addition in README doc itelf.

@mayurilahane mayurilahane force-pushed the mlahane/clouwash_readme branch from 2256530 to a5f90dc Compare July 5, 2024 22:22
Copy link
Collaborator

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick suggestion.

README.md Outdated Show resolved Hide resolved
mayurilahane and others added 2 commits July 9, 2024 17:54
@jyejare jyejare force-pushed the mlahane/clouwash_readme branch from d850301 to 3e9795c Compare July 9, 2024 12:24
@jyejare jyejare merged commit cd91c39 into RedHatQE:master Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants