-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a block for how to run the cloudwash setup locally #124
Conversation
c73a348
to
1445793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mayurilahane!
1445793
to
d08114c
Compare
README.md
Outdated
azure_tenant_id: "XXXXXXXXX" | ||
subscription_id: "XXXXXXXXX" | ||
``` | ||
* You will also need to update the bonfire config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mshriver,
After you approved this MR I remembered I had made some changes in the bonfire local config too.
So, can you please review if it's required or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider actually dropping this bonfire section, focusing on the minikube setup? IIRC there are issues with permissions in the ephemeral namespaces? I don't recall specific modifications made - because I think we ended up just using minikube to create the resources and pod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right !!
I wasn't sure about it!
anyways i just removed it
@jyejare can you please merge it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOPs I did not notice the ping. Merging.
d08114c
to
2256530
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed response. But we should add a new docs
directory and add a new doc there mentioning everything in this PR and finally just provide the source reference to the README doc.
README.md
Outdated
@@ -172,3 +171,162 @@ Removed following and all unused discs from Azure Cloud. | |||
Removed following and all unused pips from Azure Cloud. | |||
['test-axodawttrw-pip0'] | |||
``` | |||
# How to run the cloudwash setup locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create a separate doc for this and refer the document source in README. This would be a very big addition in README doc itelf.
2256530
to
a5f90dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nitpick suggestion.
Co-authored-by: Jitendra Yejare <jyejare@redhat.com>
d850301
to
3e9795c
Compare
No description provided.