Added ability to copy the update_center_certificate from a remote #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ | |||
| copy: | |||
| src: "{{ update_center_certificate }}" | |||
| dest: "{{ jenkins_home }}/update-center-rootCAs/update-center.crt" | |||
| remote_src: "{{ update_center_certificate_remote_src | default(false) }}" | |||
There was a problem hiding this comment.
Why have a default here instead of in the defaults.yml file?
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=====================================
Coverage 54% 54%
=====================================
Files 2 2
Lines 50 50
Branches 3 3
=====================================
Hits 27 27
Misses 23 23Continue to review full report at Codecov.
|
robled
force-pushed
the
uc_cert_from_remote_src
branch
from
e84d056 to
b3fdc7a
Compare
robled
force-pushed
the
uc_cert_from_remote_src
branch
from
b3fdc7a to
6c62d4b
Compare
greg-hellings
approved these changes
Feb 9, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source.