Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWATCH-2963: Count Splunk transmission failures in Quarkus apps #3813

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

awood
Copy link
Contributor

@awood awood commented Sep 30, 2024

Jira issue: SWATCH-2963

Description

We have a custom Splunk error callback that increments a counter when failures
occur during message transmission. Unfortunately, that callback was only being
applied to swatch-producer-aws. This PR applies the callback to all Quarkus
applications.

Testing

Steps

  1. On main:

    ./gradlew :swatch-contracts:quarkusDev &
    http :9000/metrics | grep splunk
    
  2. Repeat on this branch

  3. Deploy this branch again like so:

    ENABLE_SPLUNK_HEC=true \
    SPLUNK_HEC_URL=https://localhost:8088 \
    SPLUNK_HEC_TOKEN=foobar \
    ./gradlew :swatch-contracts:quarkusDev &
    sleep 20
    http :9000/metrics | grep splunk
    

    The non-existent URL will result in a bunch of message failures (although
    you will need to wait a bit for them to register). The counter will get
    incremented.

Verification

  1. On main you will not see the metric listed. On this branch it'll be there.
  2. For the last step, the counter will be non-zero.

@awood awood added QE Pull request should be approved by QE before merge Dev Pull requests that need developer review labels Sep 30, 2024
Sgitario
Sgitario approved these changes Oct 1, 2024
@Sgitario Sgitario added Dev/approved Pull requests that have been approved by all assigned developers and removed Dev Pull requests that need developer review labels Oct 1, 2024
@ntkathole ntkathole added QE Unneeded Pull request does not need QE approval and removed QE Pull request should be approved by QE before merge labels Oct 1, 2024
@awood
Copy link
Contributor Author

awood commented Oct 1, 2024

/retest

4 similar comments
@awood
Copy link
Contributor Author

awood commented Oct 2, 2024

/retest

@awood
Copy link
Contributor Author

awood commented Oct 2, 2024

/retest

@awood
Copy link
Contributor Author

awood commented Oct 3, 2024

/retest

@TrayvonMcKnight
Copy link
Contributor

/retest

@awood awood merged commit 57d1e67 into main Oct 4, 2024
22 checks passed
@awood awood deleted the awood/SWATCH-2963-splunk-failures branch October 4, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev/approved Pull requests that have been approved by all assigned developers QE Unneeded Pull request does not need QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants