SWATCH-1233: Drop UOM from the swatch #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
added
QE
Sgitario
force-pushed
the
jcarvaja/SWATCH-1233
branch
2 times, most recently
from
e007f75
to
45dac2c
Compare
wottop
requested changes
Sep 23, 2024
|
/retest |
Sgitario
force-pushed
the
jcarvaja/SWATCH-1233
branch
from
45dac2c
to
6e49a08
Compare
Updated
This is used by the floorplan queries, so it should stay as it is as noted in the JIRA description. PR updated. |
|
/retest |
liwalker-rh
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Changes look good in regression testing. I also added an IQE MR to remove variables named UOM in any test and replaced with metric_id when necessary. This will help to avoid anyone being confused about UOM still being seen in tests in the future. https://gitlab.cee.redhat.com/insights-qe/iqe-rhsm-subscriptions-plugin/-/merge_requests/874
liwalker-rh
added
QE/approved
|
/retest |
wottop
approved these changes
Sep 25, 2024
wottop
added
Dev/approved
UOM is no longer referenced in swatch openapi definitions Automation tests are no longer referencing UOM UOM is no longer referenced in SWatch code UOM is no longer stored as part of events. Double check that no queries are using UOM check bin/ scripts to make sure UOM is no longer referenced
Sgitario
force-pushed
the
jcarvaja/SWATCH-1233
branch
from
6e49a08
to
5186639
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-1233
Description
UOM is no longer referenced in swatch openapi definitions Automation tests are no longer referencing UOM
UOM is no longer referenced in SWatch code
UOM is no longer stored as part of events.
Double check that no queries are using UOM
check bin/ scripts to make sure UOM is no longer referenced
Testing
Only regression testing.