-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWATCH-2925: Prevent swatch contract service restarts on failures #3775
Conversation
Setting failure strategy to ignore when processing messages from UMB. This follows the same strategy as in offering-sync-task.
7e7d49b
to
65487ea
Compare
/retest |
1 similar comment
/retest |
This is failing in IQE due to: |
@@ -318,12 +318,14 @@ mp.messaging.incoming.offering-sync-umb.connector=smallrye-amqp | |||
mp.messaging.incoming.offering-sync-umb.address=${OFFERING_UMB_QUEUE} | |||
mp.messaging.incoming.offering-sync-umb.client-options-name=umb | |||
mp.messaging.incoming.offering-sync-umb.enabled=${UMB_ENABLED} | |||
mp.messaging.incoming.offering-sync-umb.failure-strategy=ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use a different value for these consumers since they use amqp; out of the supported values, I'm inclined to just use accept
as it's the closest in behavior to ignore
.
looks like the list of acceptable failure strategies can be found at https://github.com/smallrye/smallrye-reactive-messaging/blob/main/smallrye-reactive-messaging-amqp/src/main/java/io/smallrye/reactive/messaging/amqp/fault/AmqpFailureHandler.java#L16 |
Jira issue: SWATCH-2925
Description
Setting failure strategy to ignore when processing messages from UMB. This follows the same strategy as in offering-sync-task.
Testing
Only regression testing.