Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWATCH-2925: Prevent swatch contract service restarts on failures #3775

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Sgitario
Copy link
Contributor

Jira issue: SWATCH-2925

Description

Setting failure strategy to ignore when processing messages from UMB. This follows the same strategy as in offering-sync-task.

Testing

Only regression testing.

@Sgitario Sgitario added QE Unneeded Pull request does not need QE approval Dev Pull requests that need developer review labels Sep 23, 2024
@kartikshahc kartikshahc self-requested a review September 23, 2024 13:01
@kartikshahc kartikshahc self-assigned this Sep 23, 2024
@kartikshahc kartikshahc added Dev/approved Pull requests that have been approved by all assigned developers and removed Dev Pull requests that need developer review labels Sep 23, 2024
Setting failure strategy to ignore when processing messages from UMB.
This follows the same strategy as in offering-sync-task.
@barnabycourt
Copy link
Collaborator

/retest

1 similar comment
@barnabycourt
Copy link
Collaborator

/retest

@barnabycourt
Copy link
Collaborator

This is failing in IQE due to:
Caused by: java.lang.IllegalArgumentException: SRMSG16004: Unknown failure strategy: ignore
at io.smallrye.reactive.messaging.amqp.fault.AmqpFailureHandler$Strategy.from(AmqpFailureHandler.java:63)
at io.smallrye.reactive.messaging.amqp.AmqpConnector.createFailureHandler(AmqpConnector.java:370)
at io.smallrye.reactive.messaging.amqp.AmqpConnector.getPublisher(AmqpConnector.java:229)
at io.smallrye.reactive.messaging.amqp.AmqpConnector_Subclass.getPublisher$$superforward(Unknown Source)
at io.smallrye.reactive.messaging.amqp.AmqpConnector_Subclass$$function$$7.apply(Unknown Source)
at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:73)
at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:62)
at io.quarkus.smallrye.reactivemessaging.runtime.DuplicatedContextConnectorFactoryInterceptor.intercept(DuplicatedContextConnectorFactoryInterceptor.java:32)
at io.quarkus.smallrye.reactivemessaging.runtime.DuplicatedContextConnectorFactoryInterceptor_Bean.intercept(Unknown Source)
at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:42)
at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:30)
at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:27)
at io.smallrye.reactive.messaging.amqp.AmqpConnector_Subclass.getPublisher(Unknown Source)
at io.smallrye.reactive.messaging.amqp.AmqpConnector_ClientProxy.getPublisher(Unknown Source)
at io.smallrye.reactive.messaging.providers.impl.ConfiguredChannelFactory.createPublisher(ConfiguredChannelFactory.java:208)
at io.smallrye.reactive.messaging.providers.impl.ConfiguredChannelFactory.register(ConfiguredChannelFactory.java:146)
at io.smallrye.reactive.messaging.providers.impl.ConfiguredChannelFactory.initialize(ConfiguredChannelFactory.java:115)
at io.smallrye.reactive.messaging.providers.impl.ConfiguredChannelFactory_ClientProxy.initialize(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at io.smallrye.reactive.messaging.providers.extension.MediatorManager.start(MediatorManager.java:250)
at io.smallrye.reactive.messaging.providers.extension.MediatorManager_ClientProxy.start(Unknown Source)
at io.quarkus.smallrye.reactivemessaging.runtime.SmallRyeReactiveMessagingLifecycle.onApplicationStart(SmallRyeReactiveMessagingLifecycle.java:53)

@barnabycourt barnabycourt added Dev Pull requests that need developer review and removed Dev/approved Pull requests that have been approved by all assigned developers labels Sep 23, 2024
@@ -318,12 +318,14 @@ mp.messaging.incoming.offering-sync-umb.connector=smallrye-amqp
mp.messaging.incoming.offering-sync-umb.address=${OFFERING_UMB_QUEUE}
mp.messaging.incoming.offering-sync-umb.client-options-name=umb
mp.messaging.incoming.offering-sync-umb.enabled=${UMB_ENABLED}
mp.messaging.incoming.offering-sync-umb.failure-strategy=ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use a different value for these consumers since they use amqp; out of the supported values, I'm inclined to just use accept as it's the closest in behavior to ignore.

@barnabycourt
Copy link
Collaborator

@kahowell kahowell merged commit f3cfe93 into main Sep 24, 2024
4 of 5 checks passed
@kahowell kahowell deleted the jcarvaja/SWATCH-2925 branch September 24, 2024 18:40
@kahowell kahowell restored the jcarvaja/SWATCH-2925 branch September 24, 2024 18:56
@kahowell kahowell deleted the jcarvaja/SWATCH-2925 branch September 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Pull requests that need developer review QE Unneeded Pull request does not need QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants