-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(repository): use native SQL for history #558
refactor(repository): use native SQL for history #558
Conversation
Quarkus 3 comes with Hibernate ORM 6 which supports the JSONB type. That may be something to consider instead of transforming the queries to native SQL. |
@gwenneg does Hibernate 6 support JSONB lookups in HQL? What I've found is that there is no support for it in HQL. It complains about Upgrading to Quarkus 3 might be a heavier lift than changing to native SQL, which most of our team "speak". |
I haven't tried Hibernate 6 yet but it should support JSONB in HQL AFAIK. Regarding Quarkus 3, that bump will be mandatory sooner or later anyway because Quarkus 2 won't be supported/maintained forever 😃 |
@gwenneg Per discussion, this would be a much heavier lift at the moment. Would you have time to review this refactoring. Thank you! |
src/test/java/com/redhat/cloud/policies/app/model/history/PoliciesHistoryRepositoryTest.java
Outdated
Show resolved
Hide resolved
Refactors PoliciesHistoryRepository to use native SQL to support Postgresql-specific queries (like JSON lookups). RHINENG-1191
e86b72f
to
120c839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Refactors
PoliciesHistoryRepository
to use native SQL to support Postgresql-specific queries (like JSON lookups).RHINENG-1191