RHINENG-11011: Fix null dereference errors #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marleystipich2
approved these changes
Jul 1, 2024
vkrizan
reviewed
Jul 1, 2024
| @@ -204,7 +204,7 @@ exports.list = errors.async(async function (req, res) { | |||
| req.user.username | |||
| ); | |||
|
|
|||
| playbook_runs = playbook_runs?.toJSON(); | |||
| playbook_runs = playbook_runs?.toJSON() || {}; | |||
There was a problem hiding this comment.
If there are no playbook runs, don't we want to return right away?
There was a problem hiding this comment.
Well... sort of. This code is really bad about side effects so you have to be really careful, but we can at least break out of this 'P.map()' instance. I was in the process of changing that when I got pulled into a series of meetings but I'll push an update here shortly...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the code to handle case where sequelize returns a null.