Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the file writing client readiness #54

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

jponge
Copy link
Collaborator

@jponge jponge commented Mar 28, 2023

Readiness depends on 1) having an existing target folder, and 2) having a machine id file.

Readiness depends on 1) having an existing target folder, and 2) having a machine id file.
@jponge jponge requested review from ehsavoie and kittylyst and removed request for ehsavoie March 28, 2023 08:18
Copy link
Collaborator

@kittylyst kittylyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jponge
Copy link
Collaborator Author

jponge commented Mar 28, 2023

@mnovak1 Can you please review as well?

Copy link
Contributor

@mnovak1 mnovak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jponge jponge merged commit 4b9730c into main Mar 29, 2023
@jponge jponge added this to the 1.0.0.Beta3 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants