Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ErrorProne #258

Merged
merged 5 commits into from
Sep 24, 2024
Merged

chore: add ErrorProne #258

merged 5 commits into from
Sep 24, 2024

Conversation

kittylyst
Copy link
Collaborator

No description provided.

aslicerh
aslicerh approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@aslicerh aslicerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes that are here look fine.

I noticed that nothing was marked with @NullMarked, does that mean that none of these files have been fully gone through?

@kittylyst
Copy link
Collaborator Author

So, it looks like JSpecify in this configuration defaults to null-marking.

Anyway, I've added annotations to be explicit.

@kittylyst kittylyst changed the title DRAFT: Spike ErrorProne chore: add ErrorProne Sep 24, 2024
@kittylyst kittylyst merged commit c742557 into main Sep 24, 2024
1 of 2 checks passed
@kittylyst kittylyst deleted the spike_error_prone branch September 24, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslicerh aslicerh aslicerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittylyst @aslicerh