Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ceph specs 'ceph_v' and 'ceph_insights' to sos_archive #4233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulXs
Copy link
Contributor

@rahulXs rahulXs commented Sep 30, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

The combiner insights.combiners.ceph_version.CephVersion utilizes the following three parser classes: CephVersion, CephInsights, and CephReport. Currently, in the sos_archive.py, there is only one spec added for the sos_commands/ceph/ceph_report file.

In some sosreports, the ceph_report and ceph_insights files may contain errors instead of valid data. This issue causes the GSS rule to be skipped because the required version information is not retrieved. In such cases, the ceph_-v file contains the necessary version information. By adding the relevant specs, the GSS rule will not be skipped, ensuring a successful hit.

   ceph  cat ceph_report
Error initializing cluster client: ObjectNotFound('RADOS object not found (error calling conf_read_file)',)
   ceph  cat ceph_insights
Error initializing cluster client: ObjectNotFound('RADOS object not found (error calling conf_read_file)',)
   ceph  cat ceph_-v
ceph version 16.2.0-152.el8cp (e456e8b705cb2f4a779689a0d80b122bcb0d67c9) pacific (stable)

Signed-off-by: Rahul Sharma <rahushar@redhat.com>
@rahulXs
Copy link
Contributor Author

rahulXs commented Sep 30, 2024

This PR is a substitute for the now closed PR #4201

@Lorquas
Copy link
Member

Lorquas commented Sep 30, 2024

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (7ff8c5e) to head (5554382).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4233   +/-   ##
=======================================
  Coverage   76.88%   76.88%           
=======================================
  Files         757      757           
  Lines       41342    41344    +2     
  Branches     9526     9526           
=======================================
+ Hits        31785    31789    +4     
+ Misses       8479     8478    -1     
+ Partials     1078     1077    -1     
Flag Coverage Δ
unittests 76.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants