fix: let uname spec also support RHEL 6 #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4231 +/- ##
==========================================
- Coverage 76.69% 76.69% -0.01%
==========================================
Files 759 759
Lines 41788 41788
Branches 9603 9603
==========================================
- Hits 32051 32049 -2
- Misses 8638 8639 +1
- Partials 1099 1100 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
force-pushed
the
uname_rhel6
branch
from
05cbf3f
to
cf0c78a
Compare
xiangce
changed the title
xiangce
force-pushed
the
uname_rhel6
branch
8 times, most recently
from
2e364fa
to
ad73753
Compare
JoySnow
approved these changes
Sep 29, 2024
- On RHEL 6, uname was not in /usr/bin/ yet. Use first_of to collect "/bin/uname" as an alternative for RHEL 6 - Refine the test_fixed_by_warning due to unexpected failure in py2 CI/CD And fixed typo in warning message Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
xiangce
force-pushed
the
uname_rhel6
branch
from
ad73753
to
5b5a9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative using first_of to collect /bin/uname for RHEL 6
mockfor unexpectedfailure on test of py2
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes: