fix: Update value format of CupsBrowsedConf #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4230 +/- ##
==========================================
- Coverage 76.70% 76.69% -0.01%
==========================================
Files 759 759
Lines 41792 41788 -4
Branches 9604 9603 -1
==========================================
- Hits 32055 32051 -4
Misses 8638 8638
Partials 1099 1099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wushiqinlou
changed the title
Signed-off-by: jiazhang <jiazhang@redhat.com>
wushiqinlou
force-pushed
the
Enhance_cups_confs_CupsBrowsedConf
branch
from
7a71d94
to
a699136
Compare
xiangce
reviewed
Sep 28, 2024
| assert result['BrowseRemoteProtocols'] == ['dnssd', 'cups'] | ||
| assert sorted(result['BrowseAllow']) == sorted(['192.168.0.1', '192.168.0.255', 'cups.example.com']) | ||
| assert result['BrowseRemoteProtocols'] == ['dnssd cups', 'none'] | ||
| assert result['BrowseAllow'] == ['192.168.0.1', '192.168.0.255', 'cups.example.com', '192.168.0.255'] |
There was a problem hiding this comment.
Better add a special description (note) to the parser's doc, like:
.. note::
Values of each directives will be store as a list with the original order,
and duplicated values will be kept without de-duplication.
548b9a2
to
1419dbf
Compare
xiangce
changed the title
Signed-off-by: jiazhang <jiazhang@redhat.com>
xiangce
approved these changes
Sep 28, 2024
xiangce
pushed a commit
that referenced
this pull request
Sep 28, 2024
- Per the manual and tests of cups_browsed.conf, different directives will be handled differently. E.g, for BrowseAllow, all its configured values will be kept, but for BrowseRemoteProtocols, only its last one will work. Signed-off-by: jiazhang <jiazhang@redhat.com> (cherry picked from commit 31bfcdb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Update the value format of this parser to adjust the Advisor rule.
different directives will be handled differently. E.g,
for
BrowseAllow, all its configured values will be kept,but for
BrowseRemoteProtocols, only its last one will work.