Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: feat(RHINENG-2085): Detect when user has not access to all hosts #1982

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AsToNlele
Copy link
Contributor

@AsToNlele AsToNlele commented Aug 25, 2023

Detects when a user has not access to all systems in a policy, because of Inventory groups.

How to test:

  1. Use an account that has two users
  2. Create a Inventory group and some systems in it
  3. In Compliance create a SCAP Policy that has systems from the group and also outside of the group
  4. First User
    4.1. has permissions for all systems
    4.2. In Compliance --> SCAP Policies system count matches system count in the SCAP Policy detail page --> Systems tab
    4.3. No alert above the SystemTable in
  5. Second User
    5.1. has group:read and host:read only for the group
    5.2. In Compliance --> SCAP Policies system count is different from the system count in the SCAP Policy detail page --> Systems tab
    5.3. Alert above the SystemTable

Temporary UI

First user Second user
image image

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (c919ec5) 66.30% compared to head (c6a7824) 66.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
+ Coverage   66.30%   66.32%   +0.02%     
==========================================
  Files         211      211              
  Lines        4229     4232       +3     
  Branches     1145     1147       +2     
==========================================
+ Hits         2804     2807       +3     
  Misses       1425     1425              
Files Changed Coverage Δ
.../SmartComponents/PolicyDetails/PolicySystemsTab.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkarat
Copy link
Contributor

gkarat commented Dec 20, 2023

Rebased with the latest master ^

@gkarat gkarat changed the title DRAFT: feat(PolicySystemsTab): RHICOMPL-3946 - Detect when user has not access to all hosts DRAFT: feat(RHINENG-2085): Detect when user has not access to all hosts Dec 20, 2023
@gkarat gkarat added the enhancement New feature or request label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants