Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devel(CI): RHICOMPL-2542 set up github actions on master #1136

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

skateman
Copy link
Member

@skateman skateman commented Jan 29, 2022

Sets up some basic CI stuff in order to be able to upload coverage results to codecov.

@skateman skateman requested a review from a team as a code owner January 29, 2022 18:07
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #1136 (639b5b7) into master (fc2b33e) will increase coverage by 1.83%.
The diff coverage is 97.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   95.83%   97.67%   +1.83%     
==========================================
  Files         160      148      -12     
  Lines        3147     2794     -353     
==========================================
- Hits         3016     2729     -287     
+ Misses        131       65      -66     
Impacted Files Coverage Δ
app/graphql/types/system.rb 87.80% <50.00%> (ø)
app/jobs/parse_report_job.rb 93.87% <83.33%> (-1.78%) ⬇️
app/graphql/types/interfaces/rules_preload.rb 94.73% <94.73%> (+0.29%) ⬆️
app/consumers/concerns/report_parsing.rb 96.00% <100.00%> (ø)
app/controllers/concerns/parameters.rb 100.00% <100.00%> (ø)
app/controllers/v1/profiles_controller.rb 98.38% <100.00%> (ø)
app/graphql/mutations/profile/associate_rules.rb 100.00% <100.00%> (ø)
...pp/graphql/types/concerns/profile_pseudo_policy.rb 100.00% <100.00%> (ø)
app/graphql/types/concerns/system_profiles.rb 100.00% <100.00%> (ø)
app/graphql/types/os_major_version.rb 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8936aff...639b5b7. Read the comment docs.

@skateman skateman force-pushed the github-actions branch 6 times, most recently from 50eb877 to 12acb6a Compare January 29, 2022 20:06
@skateman skateman changed the title devel(CI): RHICOMPL-2542 set up github actions devel(CI): RHICOMPL-2542 set up github actions on master Jan 29, 2022
@skateman
Copy link
Member Author

/retest

Copy link
Contributor

@marleystipich2 marleystipich2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @skateman!

@skateman skateman merged commit f2eef65 into RedHatInsights:master Jan 31, 2022
@skateman skateman deleted the github-actions branch January 31, 2022 16:48
@sthirugn
Copy link

thank you David. I am wondering we are running the tests on ubuntu-latest? are there no centos options to pick from?

@skateman
Copy link
Member Author

skateman commented Jan 31, 2022

thank you David. I am wondering we are running the tests on ubuntu-latest? are there no centos options to pick from?

https://github.com/actions/virtual-environments#available-environments
actions/runner-images#1443 (comment)

@sthirugn
Copy link

ok thank you David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants