Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Prometheus Operator version #856

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

gburges
Copy link
Contributor

@gburges gburges commented Sep 8, 2023

No description provided.

Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't affect the prometheus that is deployed - but should be done in tandem with updating the prometheus on the cluster right?

@gburges
Copy link
Contributor Author

gburges commented Sep 8, 2023

there's no prometheus deployed on the cluster - we removed it a while ago because it wasn't cleaning up properly

@gburges gburges requested a review from psav September 8, 2023 15:05
@psav
Copy link
Collaborator

psav commented Sep 12, 2023

there's no prometheus deployed on the cluster - we removed it a while ago because it wasn't cleaning up properly

While we disabled the prometheus instances by default, the "operator" is still installed and at a much earlier version 0.56.3 this is what needs updating first.....or in tandem with the update to the CRD spec in Clowder

Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented

@gburges gburges force-pushed the promup branch 4 times, most recently from d31d21d to 51beb0d Compare September 25, 2023 15:10
@gburges gburges requested a review from psav October 2, 2023 15:15
@psav
Copy link
Collaborator

psav commented Oct 10, 2023

Is prometheus updated in the clusters now?

Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is prometheus updated in the clusters now?

We should take a look at the version we deploy in the kubebuild script too

@psav psav added technical debt Technical Debt related pr-functional-change Will result in a new binary labels Oct 10, 2023
@adamrdrew
Copy link
Contributor

We need to see that we have the correct operator versions deployed. Also, "We should take a look at the version we deploy in the kubebuild script too" from @psav can we get this looked at too?

@gburges
Copy link
Contributor Author

gburges commented Oct 20, 2023

We need to see that we have the correct operator versions deployed. Also, "We should take a look at the version we deploy in the kubebuild script too" from @psav can we get this looked at too?

Looking. I would also propose to research user workload monitoring. This all could be moot if it works well for us

@gburges
Copy link
Contributor Author

gburges commented Jan 11, 2024

/retest

2 similar comments
@gburges
Copy link
Contributor Author

gburges commented Jan 11, 2024

/retest

@gburges
Copy link
Contributor Author

gburges commented Jan 12, 2024

/retest

adamrdrew
adamrdrew previously approved these changes Jan 22, 2024
Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gburges
Copy link
Contributor Author

gburges commented Jan 23, 2024

/retest

@psav psav merged commit 6a4cb2b into RedHatInsights:master Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-functional-change Will result in a new binary technical debt Technical Debt related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants