Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clowder jenkinsfile PR Check Enhancement #792

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Clowder jenkinsfile PR Check Enhancement #792

merged 1 commit into from
Nov 13, 2023

Conversation

maknop
Copy link
Contributor

@maknop maknop commented Mar 22, 2023

No description provided.

@maknop maknop marked this pull request as draft March 23, 2023 18:48
@BumbleFeng
Copy link

/retest

2 similar comments
@maknop
Copy link
Contributor Author

maknop commented Mar 27, 2023

/retest

@maknop
Copy link
Contributor Author

maknop commented Mar 29, 2023

/retest

@maknop maknop force-pushed the maknop/jenkinsfile-prcheck-enhancement branch from 913a03f to ecf850f Compare April 3, 2023 16:18
@maknop
Copy link
Contributor Author

maknop commented Apr 5, 2023

/retest

@maknop maknop force-pushed the maknop/jenkinsfile-prcheck-enhancement branch from 750d27b to 0700dc0 Compare April 7, 2023 15:07
@maknop
Copy link
Contributor Author

maknop commented Apr 7, 2023

/retest

1 similar comment
@maknop
Copy link
Contributor Author

maknop commented Apr 10, 2023

/retest

@psav psav added testing Work related to testing pr-non-functional-change Changes anything other than the binary labels Jun 16, 2023
@maknop maknop force-pushed the maknop/jenkinsfile-prcheck-enhancement branch 2 times, most recently from ff8bf96 to 603d90b Compare October 19, 2023 14:39
@maknop maknop force-pushed the maknop/jenkinsfile-prcheck-enhancement branch 3 times, most recently from 824ae40 to acd32b7 Compare October 24, 2023 18:50
@maknop maknop self-assigned this Nov 7, 2023
@maknop maknop marked this pull request as ready for review November 7, 2023 16:23
@maknop
Copy link
Contributor Author

maknop commented Nov 7, 2023

/retest

1 similar comment
@adamrdrew
Copy link
Contributor

/retest

Victoremepunto
Victoremepunto requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't think this is in an appropriate state to be merged.

There are several spots where I don't quite understand the intention behind the changes or if the changes are actually an improvement compared to the original script.

I left comments to ask for clarification in all these places, please feel free to schedule some time to review this work together if needed.

Jenkinsfile Outdated Show resolved Hide resolved
ci/Dockerfile.unit_tests Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
ci/build_push_base_img.sh Outdated Show resolved Hide resolved
ci/build_push_base_img.sh Show resolved Hide resolved
ci/unit_tests.sh Outdated Show resolved Hide resolved
ci/minikube_e2e_tests.sh Outdated Show resolved Hide resolved
ci/minikube_e2e_tests_inner.sh Outdated Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/minikube_e2e_tests_inner.sh Outdated Show resolved Hide resolved
Victoremepunto
Victoremepunto previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, great job!

ci/unit_tests.sh Outdated Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/build_push_base_img.sh Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/minikube_e2e_tests.sh Show resolved Hide resolved
ci/build_push_base_img.sh Show resolved Hide resolved
@maknop maknop force-pushed the maknop/jenkinsfile-prcheck-enhancement branch from 54fa621 to 2e55e2c Compare November 10, 2023 19:27
@maknop maknop changed the title [WIP] Clowder jenkinsfile PR Check Enhancement Clowder jenkinsfile PR Check Enhancement Nov 10, 2023
adamrdrew
adamrdrew approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's Get This Merged!

bsquizz
bsquizz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@bsquizz bsquizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Victoremepunto
Victoremepunto approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psav psav merged commit 012b1da into master Nov 13, 2023
6 of 7 checks passed
@psav psav deleted the maknop/jenkinsfile-prcheck-enhancement branch February 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victoremepunto Victoremepunto Victoremepunto approved these changes

@adamrdrew adamrdrew adamrdrew approved these changes

@bsquizz bsquizz bsquizz approved these changes

Assignees

@maknop maknop

Labels
pr-non-functional-change Changes anything other than the binary testing Work related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maknop @BumbleFeng @adamrdrew @Victoremepunto @bsquizz @psav