[RHCLOUD-16216] Update k8s batch/v1beta1 to batch/v1 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting to shape up - but we can't merge this until UBI8/RHEL8 have the go-toolset for glolang version 1.16. |
psav
added
on hold
|
Okay I'm gonna put a pin in this for now. We're relying on |
|
@BlakeHolifield I rebased this today and it seems to be good |
psav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good bit going on here, so I'll summarize:
CronJobwas promoted tobatch/v1ink8s.io/api v0.21.0.batch/v1beta1is being removed inv0.25.0. So an API package update was needed. I went ahead and jumped to the latest onv0.22.0go1.15is no longer sufficient and at leastgo1.16is needed.github.com/go-logr/logrhad to be downgraded from1.1.0 => 0.4.0because of this controller-runtime issue, but this is a small upgrade from our current version. Latest won't work yet.