Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

Allow deps folder to be copied over to improve build time #27

Open
tlvenn opened this issue Apr 18, 2017 · 2 comments
Open

Allow deps folder to be copied over to improve build time #27

tlvenn opened this issue Apr 18, 2017 · 2 comments

Comments

@tlvenn
Copy link
Contributor

tlvenn commented Apr 18, 2017

Right now, the deps folder is in the .dockerignore and therefore not being copied over to the build image which means that all deps are retrieved from scratch.

I don't see any reason to prevent them from being copied over as it will speed up the build time significantly if this step (fetching deps) can be bypassed because the deps folder in the docker image has been warmed already.

For example, in my CI server, I run mix deps.get && mix test as a step before running mix docker.shipit. By removing the deps folder from .dockerignore, i cut the build time in half.

tlvenn added a commit to tlvenn/mix_docker that referenced this issue Apr 18, 2017
@tlvenn tlvenn changed the title Allow deps folder to be provided as docker context Allow deps folder to be copied over to improve build time Apr 18, 2017
@tlvenn
Copy link
Contributor Author

tlvenn commented Apr 24, 2017

@teamon any comment on this ? Any idea why you initially decided to dockerignore it ?

@joshuataylor
Copy link

You would have to make sure your deps are prod deps and not dev deps as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants