Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order of package exports #12

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

zaccharles
Copy link
Contributor

Hi,

Thanks for making this library.

I was getting an error using this in a Next.js project:

Module not found: Default condition should be last one

I think it's Webpack related, but I'm not really sure exactly.

Anyway, reordering the exports in package.json resolves it.

@RebeccaStevens
Copy link
Owner

RebeccaStevens commented Sep 21, 2021

I was simply just listing the exports alphabetically as I was assuming the ordered didn't matter.

I'll merge this in. Hopefully I don't forget about this and randomly one day re-alphabetize the exports.

@RebeccaStevens RebeccaStevens changed the title Re-order exports fix: order of package exports Sep 21, 2021
@RebeccaStevens RebeccaStevens merged commit 4117460 into RebeccaStevens:main Sep 21, 2021
@zaccharles
Copy link
Contributor Author

It's not very explicit IMO, but there is some mention of it here: https://webpack.js.org/guides/package-exports/#conditional-syntax
image

@zaccharles
Copy link
Contributor Author

Anyway, thanks :)

@zaccharles zaccharles deleted the patch-1 branch September 21, 2021 14:48
github-actions bot pushed a commit that referenced this pull request Sep 21, 2021
## [1.1.3](v1.1.2...v1.1.3) (2021-09-21)

### Bug Fixes

* order of package exports ([#12](#12)) ([4117460](4117460))
@github-actions
Copy link

🎉 This PR is included in version 1.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Sep 21, 2021
RebeccaStevens pushed a commit that referenced this pull request Mar 18, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Released It's now live.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants