Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types are broken from version 6 onwards #480

Closed
sftsk opened this issue Jun 3, 2024 · 0 comments · Fixed by #481 · May be fixed by OKEAMAH/Ens-doc#6
Closed

Types are broken from version 6 onwards #480

sftsk opened this issue Jun 3, 2024 · 0 comments · Fixed by #481 · May be fixed by OKEAMAH/Ens-doc#6
Labels
Resolution: Fixed The issue has been fixed. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@sftsk
Copy link

sftsk commented Jun 3, 2024

Bug Report

Since updating to version v6 and/ or v7 I am getting the following error when using this library:

Cannot find module 'deepmerge-ts' or its corresponding type declarations.
There are types at 'xxx/node_modules/deepmerge-ts/dist/node/index.d.mts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

It was working just fine in version v5.

Expected behavior

The types should be working even if moduleResolution is set to Node.

Steps to reproduce

Set up a project with the following typescript config:

 "module": "esnext",
  "moduleResolution": "Node",

When importing the library the error appears and the types are not working.
@sftsk sftsk added Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels Jun 3, 2024
RebeccaStevens added a commit that referenced this issue Jun 3, 2024
@RebeccaStevens
fix: support older module resolutions
c77a9a9 
fix #480
@RebeccaStevens RebeccaStevens mentioned this issue Jun 3, 2024
Merged
RebeccaStevens added a commit that referenced this issue Jun 3, 2024
@RebeccaStevens
fix: support older module resolutions
063675e 
fix #480
github-actions bot pushed a commit that referenced this issue Jun 3, 2024
@semantic-release-bot
chore(release): 7.0.2 [skip ci]
4a73737 
## [7.0.2](v7.0.1...v7.0.2) (2024-06-03)

### Bug Fixes

* support older module resolutions ([063675e](063675e)), closes [#480](#480)
@RebeccaStevens RebeccaStevens added Resolution: Fixed The issue has been fixed. and removed Status: Triage This issue needs to be triaged. labels Jun 3, 2024
@OKEAMAH OKEAMAH mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Fixed The issue has been fixed. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
2 participants
@sftsk @RebeccaStevens