Add modal to acknowledge user about status change on marking progress to 100% #1322
Conversation
|
@RishiChaubey31 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Also, could you please mention in the design doc that the scope of this task is limited to displaying the modal and does not include changing the status of the task? |
I have mentioned this info in the design doc. |
|
We have a reusable modal component, why are we not using it here? |
|
Can you also mention which option was selected among the 2 options provided in the figma design? I can't see that in the design doc, please add it there also. |
the reusable modal component is different from what my modal design looks the 1st option was selected as per mentioned by Ankush in the design doc comments |
|
@RishiChaubey31 Can you please check this #1322 (comment) |
|
Last comment, other changes look good. |
RishiChaubey31
dismissed stale reviews from Achintya-Chatterjee and AnujChhikara
via
94dcd45
| @@ -1223,7 +1223,7 @@ | |||
|
|
|||
| "@floating-ui/react-dom@^2.1.2": | |||
| version "2.1.2" | |||
| resolved "https://registry.npmjs.org/@floating-ui/react-dom/-/react-dom-2.1.2.tgz#a1349bbf6a0e5cb5ded55d023766f20a4d439a31" | |||
| resolved "https://registry.yarnpkg.com/@floating-ui/react-dom/-/react-dom-2.1.2.tgz#a1349bbf6a0e5cb5ded55d023766f20a4d439a31" | |||
There was a problem hiding this comment.
why this and if this then where is package file ..?
There was a problem hiding this comment.
I ran the yarn install @floating-ui/react-dom then the yarn lock file got changed, I did not change it manually.
This package was already present in the package.json file but was missing in my node modules, hence I ran this command.
* Add modal to acknowledge user about status change on marking progress to 100% (#1322) * initial commit * refactor code * added feature flag * refactored some code * changed casing and removed comments * changed to predefined colouring * removed unnecessary useCallbacks * removed onstatus function * resolved commented changes * decereased the mismatch between the modal and design doc modal * changed button color * font change * used the already created modal component * dimensional changes * refactored function * small refactoring * async await updated * applied callback on close icon * refactored to named exports * removed a div element * rounded off the rem values * put the close icon inside button wrapper * rounded off rems * rounded off rem values * Fixed: Added a button to close model. (#1312) * Close button added * Added cross button on update modal * Formatting done * All Test Passed * Unnecessery Code Removed * Fix test to check if setIsOpen is called on close button click * Tests / Add modal to acknowledge user about status change on marking progress to 100% (#1324) * initial changes * removed unnecessary lines * removed the onStatusChange tests * added one more check to ensure that the onclose() function is working * added more tests * added should before each line * added braces * added dev flag tests * added the testid check * added skip to tests * added skeleton components to pass linitng checks * added one more test case * removed skips * added a getAllByRole --------- Co-authored-by: Rishi Chaubey <155433512+RishiChaubey31@users.noreply.github.com> Co-authored-by: Aditya Zende <adityazende6710@gmail.com>
Date: 23-01-2025
Developer Name: Rishi Chaubey
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
screen-recording-2-1_5AsnMDLX.mp4
left one is the created modal and right one is the design approved
Test Coverage
Screenshot 1
Additional Notes