Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Navbar #241

Merged
merged 19 commits into from
Dec 31, 2021
Merged

Standardize Navbar #241

merged 19 commits into from
Dec 31, 2021

Conversation

shubham-y
Copy link
Contributor

Closes #240

@shubham-y
Copy link
Contributor Author

shubham-y commented Oct 18, 2021 •
edited
Loading

Earlier(Desktop):

image

After Changes(Desktop):

  • Without Signed In User
    image

  • Signed In User
    image

Earlier(Mobile):

image

After Changes(Mobile):

  • Without Signed In User
    image

  • Signed In User
    image
    image

@shubham-y shubham-y self-assigned this Oct 19, 2021
@shubham-y shubham-y added frontend feature task A big ticket item that needs to come up as a feature labels Oct 19, 2021
@shubham-y shubham-y marked this pull request as ready for review December 19, 2021 14:11
rohan09-raj
rohan09-raj suggested changes Dec 20, 2021
View reviewed changes
components/NavBar/navbar.module.css Outdated Show resolved Hide resolved
styles/globals.css Outdated Show resolved Hide resolved
styles/globals.css Outdated Show resolved Hide resolved
components/NavBar/index.js Outdated Show resolved Hide resolved
rohan09-raj
rohan09-raj suggested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@rohan09-raj rohan09-raj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these few changes. Rest all looks good to me. Great job @shubham-y

components/NavBar/index.js Outdated Show resolved Hide resolved
components/NavBar/navbar.module.css Outdated Show resolved Hide resolved
styles/globals.css Outdated Show resolved Hide resolved
components/NavBar/navbar.module.css Outdated Show resolved Hide resolved
rohan09-raj
rohan09-raj suggested changes Dec 21, 2021
View reviewed changes
components/NavBar/navbar.module.css Outdated Show resolved Hide resolved
@rohan09-raj rohan09-raj merged commit f6d3658 into Real-Dev-Squad:develop Dec 31, 2021
@akankshadharkar akankshadharkar mentioned this pull request Jan 24, 2022
Closed
@rohan09-raj rohan09-raj mentioned this pull request Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan09-raj rohan09-raj rohan09-raj approved these changes

@swarajpure swarajpure swarajpure left review comments

@akshay1502 akshay1502 akshay1502 left review comments

@prakashchoudhary07 prakashchoudhary07 prakashchoudhary07 left review comments

Assignees

@shubham-y shubham-y

Labels
feature task A big ticket item that needs to come up as a feature frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize Navbar across Real Dev Squad
5 participants
@shubham-y @prakashchoudhary07 @akshay1502 @swarajpure @rohan09-raj