chore: fix docs build #6635
Merged
chore: fix docs build #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I managed to upgrade Related: angular/angular#24000 and angular/angular#41721 |
jakovljevic-mladen
force-pushed
the
fix_building_docs
branch
from
0541027 to
951f584
Compare
| @@ -118,9 +118,8 @@ | |||
| "lunr": "^2.1.0", | |||
| "mkdirp": "^0.5.1", | |||
| "protractor": "~7.0.0", | |||
| "rehype": "^10.0.0", | |||
|
@niklas-wortmann, rebased against master and force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For some reason,remark-htmlwith version 13 doesn't generate code examples and some guide files correctly. I tried increasingremarkversion to 12, 13 and 15, but it didn't work for multiple reasons, so I had to lower theremark-htmlfrom version 13 to version 12.For example, this is how a code example looked like (without fix from this PR):
And this is the blank page from
/apiroute:This PR fixes these issues.
Edit: please check updated description.
Related issue (if exists):
None