-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scheduling with Rx-provided schedulers will no longer leak action references #6562
fix: scheduling with Rx-provided schedulers will no longer leak action references #6562
Conversation
repeat?: false | ||
): Subscription; | ||
|
||
export function executeSchedule( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic is here.
import { Subscription } from '../Subscription'; | ||
import { SchedulerAction, SchedulerLike } from '../types'; | ||
|
||
export function executeSchedule( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added two type overloads for this internal function, to make sure we don't use this in a way that would leak with poorly written user-implemented schedulers.
Good grief, I hate schedulers. |
…n references Resolves ReactiveX#6561
6526f14
to
a579864
Compare
Change looks ok, but looks like there's a new circular dependency? |
@kwonoj I've eliminated the circular dependencies as well as eliminating some more code that didn't really make sense. The circular dependency was eliminated by moving |
Resolves #6561
Note that I haven't quite figured out how I want to test this yet.