chore: update exhaust tests to run mode #5866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
exhaust
tests to use run mode.@cartant, I've got two issues/questions here:
should handle a hot observable of hot observables
is exactly the same as testshould handle a hot observable of observables
with the exception ofexpectSubscriptions
calls. I was usually addingexpectSubscriptions
calls for those tests that didn't have them and wanted to do the same for this test, but then later I found out that they're the same. What I'd suggest is to transform this test to the one which would really satisfy what it says in the title (now, it doesn't handle observable of hot observables, but rather cold ones). I'd addexpectSubscriptions
where possible. Would you agree? If yes, is it OK to do it with this PR?use like this:
I think that users could have more troubles wanting to navigate between adjacent marbles without having enough whitespace after the
const ysubs
line ends. What do you think about inlining them? Or, if inline is not an option (for whatever reason), I'd at least put them after all marbles strings.