fix(multicast,share,refCount,shareReplay): enable synchronous firehose #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use known subscriber when possible instead of returned subscription - remove unused unsubscribe from refCount Operator - add teardown logic before calling subscribe when possible - enable remaining synchronous firehose tests fixes ReactiveX#5658
ConnectableObservable contains new properties: * _waiting: boolean, it indicates whether _connection is a not yet subscription to source or not * prepare: ()=>Subscription, internal, is called to get the subscription used for the next `connect`
|
Thanks for the PR and the effort you put into it, but I'm blocking this because multicasting is going to be reimplemented: #5634 |
|
@miginmrs I'm going to close this, as we've decided that we are not going to modify the implementations of the now-deprecated parts of the multicasting API. Sorry that your work isn't going to be merged. It was, however, very helpful in figuring out what I needed to do to make the new v7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5658